Call on_chunk_sent when write_eof is called with a valid chunk #2911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2911 +/- ##
==========================================
+ Coverage 97.98% 97.98% +<.01%
==========================================
Files 40 40
Lines 7506 7508 +2
Branches 1316 1317 +1
==========================================
+ Hits 7355 7357 +2
Misses 48 48
Partials 103 103
Continue to review full report at Codecov.
|
asvetlov
approved these changes
Apr 4, 2018
|
Please merge. |
|
Yes, I will make the backport. |
pfreixes
added a commit
that referenced
this pull request
Apr 4, 2018
…H-2911) (cherry picked from commit 6a6ab7d) Co-authored-by: Pau Freixes <[email protected]>
This was referenced Apr 4, 2018
pfreixes
added a commit
that referenced
this pull request
Apr 5, 2018
(cherry picked from commit 6a6ab7d)
pfreixes
added a commit
that referenced
this pull request
Apr 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Fixes a bug with
on_chunk_sentsignal that must be triggered whenwrite_eofis called using a valid chunk.Related issue number
#2909
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.